Quote
Dorian
Update 3 (requires previous update) fixing xul windows size, the last session problem, and the download dialog.

@JohnHell
I've added kmeleon.display.xulwidth and kmeleon.display.xulheight for convenience. This affect xul windows without a default size (for example cert manager is affected but not kmprefs)

Nice, because the httpmonitor/httpfox window opened some times covering the whole screen too and it was quite annoying.

Tested and working thanks.

About the JamesD issue with downloads, I don't have that issue with update 3, nor with update 2.

But what I noticed with these tests, is that the about:downloads keep only track of the files downloaded through left clicking a file. If you right click > save as... looks like it doesn't, but I think it is related to the win2k issue of not being able to save in other drive/volume different than where it is the %temp% set. I haven't tested this thing in XP yet. But as about:downloads is quite experimental I let other to test this.

Quote
JohnHell
About the JamesD issue with downloads, I don't have that issue with update 3, nor with update 2.

And I cannot make it happen again. Was likely something that I did.

Bug

Components.utils.import('resource://gre/modules/Services.jsm');
const JSB = Components.classes['@kmeleon/jsbridge;1'].getService(Components.interfaces.nsIJSBridge);
var exampleCallback = function (arg) {
   Services.console.logStringMessage('HAS ARGUMENT: ' + (arg ? 'Yes = ' + arg : 'No'));
};
JSB.SetMenuCallback('Misc', 'Test', (function (arg) {
      return function () {
         exampleCallback(arg);
      };
   })('Test...'), '');
JSB.RegisterCmd('examplecmnd', '', exampleCallback, '');
JSB.SetAccel('CTRL SHIFT X', 'examplecmnd');

When you use accel there shouldn't be argument, but accel sends object window as an argument.
btw how 'life'

Regards

Quote
JamesD
The #2 tab becomes a copy of the #1 tab.

It was not a copy, you have to go back to get to the correct page. See the session history of the tab.
Did you retry with a clean profile? I can't really figure out the "empty tab" thing.

Anyone else have seen "empty tab" on restart?

Quote
adodupan
When you use accel there shouldn't be argument, but accel sends object window as an argument.

callbacks are called with 2 parameters: the domwindow of the active tab and a flag with not much usage for now.

Quote

btw how 'life'

As scary as ever

Another full update

This update enable plugin container for flash by default. I want you to test if flash videos still crash in fullscreen, and how kmeleon behave with that setting.

Since the gestures patch, sometimes when using scroll bar, I stay locked in scroll mode after button release. Did anyone notice this?

Quote
Dorian
Quote
JamesD
The #2 tab becomes a copy of the #1 tab.


It was not a copy, you have to go back to get to the correct page. See the session history of the tab.
Did you retry with a clean profile? I can't really figure out the "empty tab" thing.

Anyone else have seen "empty tab" on restart?

It looks like another item in my $OnLoad list. This problem appears when the "restore on demand" pref is default. I am not seeing "empty" any longer, but the #2 tab being changed from Macrolanguage2 to about:home does occur and the length of each tab changed from default to just big enough to show icon and letter K.

The question is "What is different when 'restore on demand' is FALSE?"
Is there more time/resources for OnLoad items to run? I will run some more tests, but things seem to work OK when 'restore on demand' is false.

Created new folder
Extracted all zip file - RC2 - u4
Started KM
Used preferences panel to:
Adjust title
Stop bookmarks
Start favorites
Accept cookies always until end of session
Show menu 

Made three additional tabs  set two to wiki pages and one to commands.html
Used session options to ask for last session to load at startup
Stopped KM with File > exit
Restarted KM   SUCCESS!

Added these macros - one at a time - repeat test.

1  localdocs74  Dropped commands and replaces with a tab from local docs. SUCCESS! 
2  easeread     Added this macro.  SUCCESS!
3  priortabs    Added this macro.  SUCCESS!
4  snippet      Added this macro.  SUCCESS!  It reports a list of items in $OnLoad.
5  js_flag  ==>  failed with this one-"_JS_Flag_Post" is run at $OnLoad. 


_JS_Flag_Post {
$_JSF_CurDomain = hostname( $URL );
if ( getpref( BOOL, "javascript.enabled") == false ) {
	$_JSF_Allow = getpref(STRING,"k-meleon_fjs.javascript_sites");
	if ( index($_JSF_Allow, $_JSF_CurDomain) != -1 ) { 
		macros("JS_Flag_Toggle");
		id(ID_NAV_RELOAD);
		statusbar("Reloaded with JavaScript enabled");
		}
	}
index($_JSF_CurDomain, "about:") == -1 ? $JSFlag =false : $JSFlag =true ;
}

Another dragging toolbar strange behavior, I just found playing with my mini macro.

Happens because I'm adding to that toolbar a button (never done before), as not adding it doesn't happen, through pluginmsg(toolbar.... (you know). Or maybe is because it is added to it $OnStartup because $OnInit doesn't being added. Or maybe toolbars can be only added $OnStartup, I didn't know this.

The thing is that that host toolbar, when unlock toolbars, doesn't show the "dragger". When you don't add the button through the macro, it does show.

Anyway, it can be shown again by just clicking the dragger from another toolbar, as, for example, the URL bar. Then, in that problematic toolbar, appears again the dragger. It is not hidden permanently.

I guess it happens because it can't calculate how wide is the toolbar and hides it. In fact, when I unlock it, it jumps a little to the left (the toolbar is placed in the left, next to the throbber).

EDIT: looks like if a toolbar is locked doesn't expand to show the new button.... normal behavior from my point of view.

All I said above looks more logic now...


Update 4
========

I'm not a fan of the plugin container (I had the pref set to false by user preference), but it didn't crash the few tests I did. I thought for a moment it was the ipc in hang (without closing the user profile) and force process close, but no, it was the page I was testing, that had a VK.com video, as didn't happen in YT or Dailymotion.

What I had, and I'm not the best reporter as a win2k user, is a cmd window running the plugin container that opens when flash is loaded, but that doesn't close after there is no flash elements. Must be closed manually. Probably this doesn't happen in other systems.

But no crash at full screen or normal.


About gestures, as I don't use them, I don't know how to reproduce it.



Edited 1 time(s). Last edit at 04/15/2015 09:39PM by JohnHell.

@ Dorian

I found something. I am just not sure what I have found. I was going to begin to make the 'raw' KM75 more like what my regular KM75 contained.

I made some changes to the 'Tabbed Browsing' panel. They are described below. I think I ran into some problems after that change.

I then decided to expedite my testing and use Groups2.kmm to build the last three tabs, rather than do it one tab at a time. I was surprised when the group 'three-test' produced three tabs with the same URL. I deleted that group and saved a group named 'test' with entire set of four tabs.

Notes on testing, prefs.js groups items, parts of Groups2.kmm code:

Edit: Groups2 could correctly save a group in KM 75 RC.

I set tabbed browsing as follows:

No closing button on the tab
Hide tab bar when only one tab
Attach tab buttons to tab bar
Display tab bar below tool bars
Indicate tab loading in the tab title


user_pref("k-meleon_Groups2.0", "test");
user_pref("k-meleon_Groups2.count", 1);
user_pref("k-meleon_Groups2.test.0", "file:///C:/Program%20Files/K-Meleon75RC2_raw/browser/res/localdocs/commandlineoptions.htm");
user_pref("k-meleon_Groups2.test.1", "file:///C:/Program%20Files/K-Meleon75RC2_raw/browser/res/localdocs/commandlineoptions.htm");
user_pref("k-meleon_Groups2.test.2", "file:///C:/Program%20Files/K-Meleon75RC2_raw/browser/res/localdocs/commandlineoptions.htm");
user_pref("k-meleon_Groups2.test.3", "file:///C:/Program%20Files/K-Meleon75RC2_raw/browser/res/localdocs/commandlineoptions.htm");
user_pref("k-meleon_Groups2.test.count", 4);
user_pref("k-meleon_Groups2_History.0", "three_test");
user_pref("k-meleon_Groups2_History.count", 1);
user_pref("k-meleon_Groups2_History.three_test.0", "http://kmeleon.sourceforge.net/wiki/MacroLanguage2";
user_pref("k-meleon_Groups2_History.three_test.1", "http://kmeleon.sourceforge.net/wiki/MacroLanguage2";
user_pref("k-meleon_Groups2_History.three_test.2", "http://kmeleon.sourceforge.net/wiki/MacroLanguage2";
user_pref("k-meleon_Groups2_History.three_test.count", 3);


_Groups2_RunCode_Save {
macroinfo = _("Save the current tab's URLs as a group.");
$_Groups2_Name = prompt(_("Assign a name to save this group of tabs."), _("Group Name to save"));
macros(_Groups2_Symbols);
if ($_Groups2_Name != "") {
		macros("_Groups2_ObtainC");
		if ($_Groups2_Match == "true") {
				$_Goverwrite = confirm(_("Group name: '") . $_Groups2_Name . _("' already exist.\nDo you want overwrite it?"), _("Group Name to save"), YESNO, QUESTION);
				$_Goverwrite == "YES" ? plugin(macros, "_Goverwrite(" . $_Groups2_Name . ")") : 0;
		} else {
				setpref(STRING, "k-meleon_Groups2." . $_Groups2_Exist_Count, $_Groups2_Name);
				$_Groups2_Exist_Count = $_Groups2_Exist_Count + 1;
				setpref(INT, "k-meleon_Groups2.count", $_Groups2_Exist_Count);
				$_Groups2_Number_of_Tabs = $TabNumber;
				$_Groups2_Tab_Count = 0;
				while ($_Groups2_Tab_Count < $_Groups2_Number_of_Tabs) &_Groups2_Save_Loop;
				&_Groups2_BuildGroupsMenu;
		}
}
}

_Groups2_Save_Loop {
$_Groups2_Tab_Count == 0 ? setpref(INT, "k-meleon_Groups2." . $_Groups2_Name . ".count", $_Groups2_Number_of_Tabs) : 0;
id(ID_TAB_NEXT);
setpref(STRING, "k-meleon_Groups2." . $_Groups2_Name . "." . $_Groups2_Tab_Count, $URL);
$_Groups2_Tab_Count = $_Groups2_Tab_Count + 1;
}

Edited 1 time(s). Last edit at 04/16/2015 12:51AM by JamesD.

I had planned to test all morning, but got stuck with a new problem. I was trying to automate some of the settings so I could test new versions quicker. I made the following macro but things don't seem to happen correctly. I should be a 'do once and stop' situation, but it does not stop. I do not know if it is my macro or a bug. I have tried on a clean install and one with all four updates. Sometimes the alerts are not in the correct order.

mysetup.kmm

# K-Meleon Macros (http://kmeleon.sourceforge.net/wiki/index.php?id=MacroLanguage2)
# File name: mysetup.kmm
# --------------------------------------------------------------

_mysetup_Startup {
 setpref(BOOL, "browser.tabs.autoHide", true );
 setpref(BOOL, "kmeleon.plugins.bookmarks.load", false );
 setpref(BOOL, "kmeleon.plugins.favorites.load", true );
 setpref(BOOL, "kmeleon.tabs.fixedBar", true );
 setpref(STRING, "kmeleon.tabs.position", "top" );
 setpref(BOOL, "kmeleon.tabs.useLoadingIcon", false );
 setpref(BOOL, "kmeleon.tabs.useLoadingTitle", true );
 setpref(INT, "network.cookie.cookieBehavior", 0 );
 setpref(INT, "network.cookie.lifetimePolicy", 2 );
 alert("has set the prefs.", "_mysetup_Startup", INFO);
}

_mysetup_Done {
 setpref(BOOL, "kmeleon.plugins.macros.modules.mysetup.load", false );
 alert("load is set to false.", "mysetup.kmm", INFO);
}

# -------------------------------------------------------------
$OnLoadOnce = $OnLoadOnce . "_mysetup_Done;";
$OnStartup = $OnStartup . "_mysetup_Startup;";
$macroModules = $macroModules . "mysetup;";

@JamesD: try the attached plugin for the group macro.
OnStartup can happen after OnLoad, why not using OnSetup?
About js_flag, restore on demand does not like id(ID_NAV_RELOAD) in OnLoad, but I should be able to fix that.



Edited 1 time(s). Last edit at 04/16/2015 04:47PM by Dorian.

Quote
Dorian
@JamesD: try the attached plugin for the group macro.
OnStartup can happen after OnLoad, why not using OnSetup?
About js_flag, restore on demand does not like id(ID_NAV_RELOAD) in OnLoad, but I should be able to fix that.

I did change the event for the item in mysetup. The alerts are in the correct order. However the action to set mysetup not to load is not working. Should I try togglepref instead?

_mysetup_Done {
 setpref(BOOL, "kmeleon.plugins.macros.modules.mysetup.load", false );
 alert("load is set to false.", "mysetup.kmm", INFO);
}

Regarding the new macros.dll and groups, there seems to be no change. Please note the test was performed on a clean install with only the Groups2 module loaded. The prefs in mysetup were changed from default. The plan was to add the two tabs in the group to the existing tab which had the start page.

Before:


After


From prefs.js:

user_pref("k-meleon_Groups2.0", "test dll");
user_pref("k-meleon_Groups2.count", 1);
user_pref("k-meleon_Groups2.test dll.0", "http://kmeleon.sourceforge.net/wiki/CommandIDs";
user_pref("k-meleon_Groups2.test dll.1", "http://kmeleon.sourceforge.net/wiki/CommandIDs";
user_pref("k-meleon_Groups2.test dll.count", 2);

 



Edited 1 time(s). Last edit at 03/21/2016 12:12PM by adodupan.

I have narrowed the problem with sessions down to two prefs in tabbed browsing.

I did another clean install and ran tests without any macros of my own.
I did all the pref changes, one by one, and retested each time. All was just fine and the last session was restored OK until I changed the two prefs in tabbed browsing > tab bar the set the loading to show in tab icon or tab title.

I un-checked icon and checked title and the next start was failure with two empty tabs.

System used had all four updates and new macros.dll.

@ Dorian

The fix for sessions, the two prefs, does not help the problem with Groups.

Quote
adodupan

Quote
Dorian

Quote
adodupan
When you use accel there shouldn't be argument, but accel sends object window as an argument.

callbacks are called with 2 parameters: the domwindow of the active tab and a flag with not much usage for now.

To see the difference, you should try code above in beta3, there works fine.
consoleservice should be enabled

Sure it does, it was added after beta 3, with the experimental places extension.

 



Edited 2 time(s). Last edit at 03/21/2016 12:14PM by adodupan.

Update 5

Apart the fixes for JamesD macro, there is also a change for SetButtonImage so that changing cold image doesn't change the hot one.

Quote
adodupan
How to remove menu item added by SetMenuCallback?
This would be really useful.

SetMenu should be able to remove it, with the label and no command.



Edited 1 time(s). Last edit at 04/17/2015 06:34PM by Dorian.

 



Edited 1 time(s). Last edit at 03/21/2016 12:14PM by adodupan.

Quote
Dorian
Update 5

Apart the fixes for JamesD macro, there is also a change for SetButtonImage so that changing cold image doesn't change the hot one.

Very close to perfect now. I have a clean install thru update 5. My only addition is Groups2.kmm. Group saved in one session can be loaded in another and has correct URLs. Automatically loading the last session works.

The only problem is that when the two items in Tabbed Browsing - Tab Bar are changed from the default, the loading of a group shows 'Empty' tabs. However clicking on each tab does load the correct URL. If I return to defaults for those two items, everything works.
"Indicate page loading in tab button title"
"Indicate page loading in tab button icon"

I will now add two macro modules which have items in $OnLoad event and check if they make a difference.

I did some more testing and everything works with the two items in Tabbed Browsing set to default with one very specific exception.

I have saved a group consisting of wiki Macrolange2 and Command ID pages. If I open KM to the start page and load the group then I have three tabs which display correctly. If I then set sessions to load the last session, close KM by File - exit and restart KM, I will get all three tabs. However I must do a force reload in order to display the #2 tab. The URL is displayed and the title is in the tab, but the display is blank until I do a reload.

I have easeread, priortabs, js_flag, and groups2 modules loaded.

K-Meleon 75.0 RC2 very close to being perfect

Except that Klassic Skin still has has problems with buttons not arranging properly buttons on the same line as the mainbar

Also View toolbars has problems with buttonss on same line as mainbar So when a button is checked or unchecked the go buttons next to the address bar moves to the left leaving space after it even when the toolbar is locked.



Edited 1 time(s). Last edit at 04/19/2015 04:18PM by George_Hall.

There's a bug that's been noticeable for a while. The bug is that http://www.cnn.com/2015/04/19/us/ohio-new-richmond-officer-does-not-shoot-suspect/index.html displays weirdly until it's refreshed.

@ Zero3K

I did not notice a problem. There was a long wait time after clicking flashblock symbol until the advertisement loaded.

I don't know if I'll finish my macro or even make it public, but finding weird behaviors in K-meleon has been half of my time LOL half because of lack of experience on macro functions behavior, such as setmenu and toolbars, and others... real weird things.


Ok, here is another one:

if you set a menu to DocumentPopup (default K-meleon menu) like "setmenu("DocumentPopup", inline, "menuname");" and the page you are visiting has a background image set with css style like "style="background-image: url('whatever.jpg');"", then that menu item isn't shown.

Actually what isn't shown is the popup attached to the inline and my guess is that the inline disappears too. So we could say that what disappears is the popup, from my point of view. Nop, tested right now and happens with all kind of items attached to DocumentPopup.

I've tested this setting the background image to body; a div, first child of body, but not covering the whole width and height; and even to html, just for testing purposes.

Best site to test and came to my mind now with a background https://www.bing.com/

In this case, the background is set by javascript (backgroundImage), but it isn't a problem as the result is the same.

As I said, weird as hell.

Quote
JohnHell
tested right now and happens with all kind of items attached to DocumentPopup.

Does this only happen to popup and inline items? I have several macro and command items in my DocumentPopup and they all appear at the Bing site. What about Page Properties and Send Page to popups? I am seeing those.

Could this relate to your Ops Sys? I am using Win 7.

Don't know and can't test online in 75, but first thought for a workarounds... insert the popup into one of the native inline menus?

@ JohnHell

I think it must be your system. I changed a group of 'command' setmenu statements and moved them into a popup. I have the Bing site in another tab now and I can see my new popup appear whenever the cursor is on the popup name. I will include my code so that you can check your code against it.

page_js_switchp.kmm

# K-Meleon Macros (http://kmeleon.sourceforge.net/wiki/index.php?id=MacroLanguage2)
# File name: page_js_switchp.kmm
#
# ---------- popup menu for testing page_js_switchs for K-Meleon 75 ----
# --------------------------------------------------------------------------------

_page_js_switchp_BuildMenu {
if ($VERSION >= 33619974 ) {
    setmenu("DocumentPopup", popup, "Page JS Switching", "Page &Properties");
    setmenu("Page JS Switching",command,"page_js_toggle","ID_PAGE_TOGGLE_JS",);
    setmenu("Page JS Switching",command,"page_js_enable","ID_PAGE_ENABLE_JS","page_js_toggle");
    setmenu("Page JS Switching",command,"page_js_disable","ID_PAGE_DISABLE_JS","page_js_enable");
    setmenu("DocumentPopup",separator,"Page &Properties");
    }
}
## - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
$OnInit=$OnInit."_page_js_switchp_BuildMenu;";
$macroModules=$macroModules."page_js_switchp;";

@ Dorian

The previous post for JohnHell required me to restart the session in order to get my new macro read and the old one marked not to load. I had the Bing site in tab two. When restarted that tab required a 'Reload' in order to see the Bing site. I have a copy of the sessions files here: https://dl.dropboxusercontent.com/u/1522294/Bing_session.7z

Quote
JamesD
@ JohnHell

I think it must be your system. I changed a group of 'command' setmenu statements and moved them into a popup. I have the Bing site in another tab now and I can see my new popup appear whenever the cursor is on the popup name. I will include my code so that you can check your code against it.

Happens the same.

For a moment I thought if it could be the OnInit, as I had to use OnStartup to be able to draw a button in a toolbar, as OnInit didn't work, but after test your code, it is the same.

It is not the Operative System, but I found the problem and it was my fault, but I'll explain.

The thing is that when a document, and not necessary to be the body or html, so a div, and not needed to cover the whole viewport, but clicking enough over it, has an image set as background via CSS, the DocumentPopup loses the control and passes it to DocumentImagePopup, even you aren't right clicking actually over an image. An image understood as the tag <IMG>. Even though, K-meleon passes the control to DocumentImagePopup.

I wasn't expecting it.

As I said a few times, my context menu is all custom, but in a fresh profile I didn't expect it as DocumentPopup is a default menu, but not DocumentImagePopup, which has attached DocumentPopup.

And here was my fault. My default menus.cfg is modified to remove context menu references and leave only defaults, and didn't restore the original to test in the fresh profile, where it is set DocumentImagePopup to hold the DocumentPopup. Therefore when clicking over a background image set by CSS, DocumentImagePopup doesn't exists and the attached menu DocumentPopup doesn't either, so vanishes.

But in my defense I'd say that I thought DocumentImagePopup only was shown to actual images set as <IMG> not via CSS

EDIT 2: and the above is quite dumb, because for that exists ImagePopup...

Long story short: new thing learned.

Sorry to bother


Note that I'm not suggesting that DocumentImagePopup has DocumentPopup attached to it by default. In fact, that would prevent, partially, customization by users



Edited 2 time(s). Last edit at 04/20/2015 03:45PM by JohnHell.