tab close button [x] toggle
Posted by: disrupted
Date: September 02, 2009 07:55PM

http://kmext.sourceforge.net/macros/tabclosebtn.7z

easily enable or disable the tab close button. changes take effect instantly(no restart required)
requires atleast km 1.5.1

access: tab button context menu>enable x button


# K-Meleon Macros (http://kmeleon.sourceforge.net/wiki/index.php?id=MacroLanguage)

# ----------tab close button toggle-----------------------


tab_closebtn{
menuchecked=getpref(INT,"browser.tabs.closeButtons");
togglepref(INT,"browser.tabs.closeButtons",1,0);
$btnactive=getpref(INT,"browser.tabs.closeButtons");
$btnactive==1?&btnon:&btnoff;
}

btnon{
statusbar("tab close button enabled");
}

btnoff{
statusbar("tabclose button disabled");
}

tabbtnclose_BuildMenu{
setmenu("TabButtonPopup",inline,buttonclose_tabs,5);
setmenu(buttonclose_tabs,macro,"Enable X Button",tab_closebtn);
}

$OnInit=$OnInit."tabbtnclose_BuildMenu;";
# --------------------------------------------------------------------
$macroModules=$macroModules."tabclosebutton;";


Re: tab close button [x] toggle
Posted by: siria
Date: September 19, 2009 10:41PM

PERFECT!! Thanx! grinning smiley

Re: tab close button [x] toggle
Posted by: Alex.Tarantul
Date: September 24, 2009 10:45PM

@disrupted
My Kmeleon 1.5.3 finishes work at with that macro... CRASH! sad smiley

Re: tab close button [x] toggle
Posted by: disrupted
Date: September 24, 2009 11:07PM

yes, jamesd also reported same problem

what is your windows version and are you using a theme like xp luna or vista aero..if so, then you can confirm for us that there's a bug with the close button and windows themes.

please try this(if you are using a theme) open display properties >themes and select windows classic and see if you're still getting a crash(it might be a good idea to restart the computer after changing to classic theme before testing in kmeleon)

Re: tab close button [x] toggle
Posted by: Alex.Tarantul
Date: September 25, 2009 12:32AM

@disrupted
Windows XP SP3, but I don't use any theme like xp luna or vista aero. I'm a fan of simply interfaces grinning smiley
With Classical theme my Kmeleon crashes too! sad smiley I don't know where the problem now...Strange situation. sad smiley

Re: tab close button [x] toggle
Posted by: desga2
Date: September 25, 2009 01:13AM
Re: tab close button [x] toggle
Posted by: disrupted
Date: September 25, 2009 02:34AM

it sounds like sp3.. both alex and james have sp3, maybe one more tester with sp3 can confirm the bug.. i think charlie caktus has sp3 too

alex, if you have the crash report plugin or download it and when it crashes it will prompt to send the dump to the project and maybe dorian can understand the bug.

i don't know anything about c++ or how dorian draws the button on the tab but there's this command backgroundstyle that has been reported to cause application crashes in other programs



Edited 1 time(s). Last edit at 09/25/2009 02:40AM by disrupted.

Re: tab close button [x] toggle
Posted by: JamesD
Date: September 25, 2009 05:07AM

A family member has given me an old computer to test for him. I am pretty sure that it has only SP2 on it. If I can find time tomorrow, I will try the X on tab there and report results. I cannot find any mention of a 'luna' theme on my machine. The theme that is running just says 'modified'.

Re: tab close button [x] toggle
Posted by: jsnj
Date: September 25, 2009 10:41AM

SP3 with a modern Visual Style theme here. No crash. Shrug?



Edited 1 time(s). Last edit at 09/27/2009 06:28AM by jsnj.

Re: tab close button [x] toggle
Posted by: Alex.Tarantul
Date: September 25, 2009 01:02PM

@desga2
When I change the pref manually (I read FAQ) Kmeleon has abnormal finished work in 1 second sad smiley Crash again!
I can't open Kmeleon normally; the browser did not work absolutely until then while I have not removed manually a line
user_pref("browser.tabs.closeButtons", 1); from prefs.js

The interesting fact: I have removed a tabclosebtn.kmm from a folder of macroes and have again tried to change a configuration manually (in about:config). Also there was again an error in browser work! Thus, even without a tabclosebtn.kmm the browser breaks because of configuration change!

@disrupted
Where I can download the crash report plugin? On http://kmext.sourceforge.net/ ? How it is called?

@JamesD
Try to change theme to "Classic"



Edited 4 time(s). Last edit at 10/21/2009 12:25PM by Alex.Tarantul.

Re: tab close button [x] toggle
Posted by: JamesD
Date: September 25, 2009 07:18PM

I changed theme to Classic and added the macro for the x toggle. When I tried the x toggle from the tab menu, KM failed. Bye the way, the Classic theme is ugly.

Going to try the other computer now. I have to connect it to display, KB and mouse first.

Update:

I tried the macro on the other machine. KM failed there also. The second machine has XP-Pro-SP2 (build 2600). My desktop has XP-Home-SP3 (build 2600).

In both cases, a little box appears in the lower right corner of the tab but I did not see an 'x' in the box. Shortly after the box appears the error message appears.

Does font have anything to do with x on tab? I have the following.
user_pref("font.minimum-size.x-western", 14);
user_pref("font.name.fantasy.x-western", "Blackadder ITC");

I will be happy to test anything else, if that will help.



Edited 1 time(s). Last edit at 09/25/2009 08:06PM by JamesD.

Re: tab close button [x] toggle
Posted by: disrupted
Date: September 25, 2009 10:37PM

thanks james for the trouble.. atleast we know it's not themes and sp3 is innocent..it appears to affect some xpees and not all cause i have xp and it's working alright.. i think win 2k and 98 are not having problems, siria has win98 ..i wonder if some vistas might crash. it's definitely a bug but we can't tell what's causing it so dorain has to figure it out from a crash dump

alex, the crash report plugin can be downloaded from there:
http://kmeleon.sourceforge.net/forum/read.php?3,60195

i'll also add it under kplugins, thanks for mentioning this

i reported the bug:
http://kmeleon.sourceforge.net/bugs/viewbug.php?bugid=1150
alex..please activate the pref with the crash plugin active and make it crash then send the dump to dorian



Edited 1 time(s). Last edit at 09/25/2009 10:47PM by disrupted.

Re: tab close button [x] toggle
Posted by: siria
Date: September 26, 2009 12:18AM

Just copied my whole KM-folder over to a Vista32 notebook (Business/2006).
The close buttons work perfect, no crash.
(Just why over there the menus are displayed in double lines, meaning always an empty line in between?! That thing stays weird!)

Re: tab close button [x] toggle
Posted by: Alex.Tarantul
Date: September 26, 2009 12:57AM

@disrupted
OK. Crash again! I install the Crashreporter and it send the dump (Report number 810)...

Re: tab close button [x] toggle
Posted by: JamesD
Date: September 26, 2009 02:52AM

I just sent crash report from my desktop unit, XP-SP3. Crash report was # 811.

Re: tab close button [x] toggle
Posted by: mslayer
Date: September 26, 2009 05:28AM

The pref doesn't crash for me under win98se.
Could this problem be related to an special DLL dependency? or a graphics card configuration (color depth)? Screen resolution maybe? I'm shooting in the dark, but it can be anything 'cause these close-buttons don't look like the standard buttons.

Re: tab close button [x] toggle
Posted by: desga2
Date: September 26, 2009 05:35AM

No problem in Win2000 SP4.

K-Meleon in Spanish

Re: tab close button [x] toggle
Posted by: guenter
Date: September 26, 2009 08:45AM

Quote
desga2
No problem in Win2000 SP4.

Win2000 was the last OS made by MS - now they produce desease like Vista.

Re: tab close button [x] toggle
Posted by: Alex.Tarantul
Date: September 26, 2009 10:30AM

Quote
guenter
Win2000 was the last OS made by MS - now they produce desease like Vista.
Try Windows7 grinning smiley It is in the web now

Re: tab close button [x] toggle
Posted by: guenter
Date: September 26, 2009 08:23PM

Quote
Alex.Tarantul
Quote
guenter
Win2000 was the last OS made by MS - now they produce desease like Vista.
Try Windows7 grinning smiley It is in the web now

confused smiley Is "web" another word for my new Amilo Laptop PC, 7 test version is installed there grinning smiley

I'd swap Windows 7 if it gets me Win 2000 drivers for the Amilo drool smiley



Edited 1 time(s). Last edit at 09/26/2009 08:55PM by guenter.

Re: tab close button [x] toggle
Posted by: Alex.Tarantul
Date: May 23, 2010 01:52PM

Now I have received information that the discussed bug#1150 detected in Windows7x86.
We must seriously examine the issue. Now, even on XP error and crash the browser is not at all computers. May be a conflict with some other setting (some else key in about:config)?

My blog about K-Meleon
http://kmeleon-ru.blogspot.com/

Re: tab close button [x] toggle
Posted by: Alex.Tarantul
Date: May 29, 2010 03:38PM

Colleagues, I have important information about the error. How do I tell one of the Russian colleagues, that the tab close button worked correctly without falling browser, you immediately when you first start to activate this setting. Then you can add any extension and the conflict will not. Just from the beginning to activate the option!

My blog about K-Meleon
http://kmeleon-ru.blogspot.com/

Re: tab close button [x] toggle
Posted by: JamesD
Date: May 29, 2010 06:03PM

Alex is on to something. I had an unchanged install of 1.6 beta and following his information, I edited my prefs.js file and added the pref for x on tabs set to 1. KM opened just fine. I added tabs just fine.

Next I added one user macro. That worked.

Next I changed from bookmarks to favorites and changed the skin to Klassic. I also unchecked 'Display menu icons', 'Display website icons', and 'Display keyboard accelerater in menus'. KM failed on next restart.

I will have to go back and do the last changes one item at a time to see which thing caused the failure.

Update:

The problem item is 'Display website icons'. It must be checked for the x on tabs to work.



Edited 1 time(s). Last edit at 05/29/2010 06:23PM by JamesD.

Re: tab close button [x] toggle
Posted by: disrupted
Date: May 31, 2010 01:26AM

good find james. tested here caused crash as well with icons disabled.. think dorian can fix it now

Re: tab close button [x] toggle
Posted by: JamesD
Date: May 31, 2010 05:41AM

I don't see where we actually made a bug report. Do we have enough information to do that now?

Alex.Tarantul should get the credit. He set me looking at a clean install. I always got an error because I always run with icons turned off.

Re: tab close button [x] toggle
Posted by: disrupted
Date: May 31, 2010 06:55PM

yes, alex ofcourse.
alex explained your findings in the report http://kmeleon.sourceforge.net/bugs/viewbug.php?bugid=1150

it seems that when the icons are disabled causing the tab height to shrink and the close button doesn't find enough space to draw on the button triggering the crash

if that's the case, dorian should be able to fix it easily.. either with a fixed height for tab buttons or reducing the close button size to draw properly insiden the shrunken tab

Re: tab close button [x] toggle
Posted by: JamesD
Date: May 31, 2010 08:24PM

Great! Bug 1150 is there and updated.

K-Meleon forum is powered by Phorum.