Development :  K-Meleon Forum
K-Meleon development related discussions. 
searchbar plugin v0.0.2
Posted by: rmn
Date: March 28, 2006 02:34PM

Here's for you who prefer a separate search bar. This plugin is just an update of Romanito's version, adding a few bells and whistles (and bugs):

* Get search engine from pref "keyword.URL".
* Escape some chars.
* Added experimental SetFocus command. (I know it barely works, don't tell me about it.)

searchbar plugin

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: guenter
Date: March 29, 2006 08:00PM

thx for the work done - time spent for us. greetz to down under.

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: ndebord
Date: March 30, 2006 12:17PM

rmn,

The searchbar plugin zip file appears to be corrupted. Tried to download it twice and could not extract the searchbar.dll from the archive.

N

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: rmn
Date: March 30, 2006 06:39PM

Aha. Sorry, forgot to put the instructions. Since Geocities does not like 7z files, I had to rename them to zip. Just remove the ".zip" part of the filename and open it using 7-Zip (I heard that WinRAR also works).

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: ndebord
Date: March 31, 2006 06:27AM

rmn,

Much as I like 7-Zip, it is too fincky for most sites, so I use Power Archiver and good old-fashioned PKZIP 2.50 (DOS).

N

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: ndebord
Date: March 31, 2006 09:42AM

rmn,

Can't get it to open, so will pass on this one for now.

N

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: rmn
Date: March 31, 2006 03:47PM

That's weird, I can open it just fine. I've uploaded a normal zipped version of the binary, if you want to try.

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: guenter
Date: April 01, 2006 12:16AM

ndbord,

http://rapidshare.de/files/16881172/searchbar.dll.html

i tried upload only the dll binary for You
hope this does the trick - else this bar does like You old pc and says tongue sticking out smiley

- tested ok here with Dorians/kko┬┤s k-m-panel chrome testing 2b. dll works here.
thx again rmn - if You want it deleted i can send kill code. greats

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: ndebord
Date: April 01, 2006 02:57AM

rmn,

That did it! Got it and it works fine. Now to play with it and see what it can do!

TKS

N

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: ndebord
Date: April 01, 2006 02:59AM

rmn,

No need to go for kill code. On this verson of KM (0.9, GRE 1.7.5 updated to Brian's latest 1.7.13 patch), Edit/Preferences/Plugins enable/disable works just fine with your searchbar plugin.

N

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: rmn
Date: April 01, 2006 08:13AM

Kill code what? I don't understand.... If you are talking about the dll-only download then, yes, please remove it. It contains Romanito's code released under GPL, so theoretically we can't distribute it without the GPL text.

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: ndebord
Date: April 01, 2006 09:17AM

rmn,

My mistake, as I was reading your post about kill code and misunderstood what you were saying there.

N

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: guenter
Date: April 02, 2006 04:43AM

well compiled rmn - i use with 1.0 - ndbord with 0.9! great.

I will remove. did upload that only - so that nothing can interfere.
can not kill from here - may take some time.
alternately i could add usage conditions to my post?
Like: download is under GNU - do not download if You do not accept condition.

p.s. i would have posted kill code but the last time i did - some joker killed the file before the recepient had downloaded.

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: ndebord
Date: April 02, 2006 11:26PM

Guenter and rmn,

Yes, I use it with 0.9 (Brian's latest update) and it works fine.

N

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: rmn
Date: April 03, 2006 09:05PM

Do you find this plugin useful? Personally, I prefer keyword-searching from the URL bar.

I'm only updating the plugin so you can point it out to people looking for "Google bar". :-)

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: bst82551
Date: April 04, 2006 09:23AM

I'm with you, rmn... having one bar makes things a little less complicated and leaves more real estate for the actual webpage. I like it that way. I have trimmed down my toolbars to only have the bare minimum, as you can see here:
http://tinypic.com/view/?pic=sy9vg5

I leave lots of space for what I use a lot and little space for what I rarely use. That's the way it should be, after all- much more effecient that way.

Brian

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: ndebord
Date: April 06, 2006 01:15AM

rmn,

I like the searchbar, but I too have a small screen (12.1) and right now I have edited KM's look down to 2 bars, the Main and the icon line (with privacy bar edited down to fit on that bar). I use too use search from the URL dialog box instead, but from time to time, I enable this search plugin and it is useful, even though it takes up real estate.

N

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: guenter
Date: April 06, 2006 01:13PM

i dont like search from URL better - whatever I like: increasing choice is good.

btw: i easily can use Google bar as alternative - it is one of the extensions that work.
confer 0.8.2+ that had it.

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: rmn
Date: April 06, 2006 11:17PM

guenter, does Google bar work in 0.9 and 1.0beta?

By the way, I've just found a strange bug with this plugin. You can't type exceeding the textbox size. I'll look at it, but I don't think I'll be able to fix it.

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: Dorian
Date: April 07, 2006 04:10AM

I can easily fix the focus and the size problem, and add unicode support to it.

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: rmn
Date: April 08, 2006 09:57AM

Oh, thanks, that would be great!

I really want to know how to fix the focus problem, since I don't know how to associate the textbox to each window/layer so the SetFocus() function works on that window's searchbar. I was thinking of storing them + their parent window handle in a linked list and searching through the list for "current window", but that seems overkill, plus introducing O(n) list-searching.

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: rmn
Date: April 08, 2006 10:08AM

Another thing: the code to escape characters is horrible (and will not work well with Unicode); I wonder if there is a URL encoder function in the plugin API?

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: rmn
Date: April 08, 2006 11:04AM

OK, I got rid of the size bug by adding ES_AUTOHSCROLL to dwStyle.

But I just found a major bug similar to the SetFocus bug (I don't understand how I missed this before): the search text is always taken from the last created editbox.

And another one (also related to the problem with SetFocus): I think it's leaking. There are no code to destroy the editbox when a window is closed.

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: Dorian
Date: April 08, 2006 02:22PM

You can use the SetProp API to associate data with a window.
As for leak there is none, a window is automatically destroyed with its parent.

Searchbar 0.03
utf.h is needed just to support W95 .....


If you interested in trying to support Search Plugins I can add automatic install of thoses in k-meleon.

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: rmn
Date: April 10, 2006 12:39AM

Thanks, but (pardon my ignorance) where is the _T macro defined?

> If you interested in trying to support Search Plugins I can add automatic install of thoses in k-meleon.

Looks interesting, but perhaps not now; it seems to be way beyond my skills. Also, I don't know if it's worth the addition to the core.

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: Dorian
Date: April 10, 2006 11:57PM

Thanks, but (pardon my ignorance) where is the _T macro defined?

In tchar.h, but you don't need it actually, you can just add:
#define _T(x) x

Options: ReplyQuote
Re: searchbar plugin v0.0.2
Posted by: rmn
Date: April 14, 2006 02:41PM

OK, I got it running. I'll clean it up and release soon.

Options: ReplyQuote


K-Meleon forum is powered by Phorum.