Development :  K-Meleon Forum
K-Meleon development related discussions. 
Bug 113007 Patch
Posted by: ZeroMC
Date: July 05, 2002 01:11PM

Hi *

what about this:

The problem seems to be simply that MFCEmbed does not implement ShowAsModal().
When WindowWatcher makes a new modal window, it tries to call this. MFCEmbed
just returns NS_ERROR_NOT_IMPLEMENTED.

My fix was simply to borrow some code I found in WinEmbed (its version of
ShowAsModal()) and modify it slightly to make it work. I've attached a patch
for BrowserImpl.cpp. (Or at least I've tried to... I am not yet learned in
the ways of diff and patch... Sorry if it's not a proper patch.)

Is it fixed?

Is it now possible to continue development ? ;)

best regards

ZeroMC

Options: ReplyQuote
Re: Bug 113007 Patch
Posted by: Andrew
Date: July 05, 2002 02:03PM

ZeroMC,

We never stopped development. First, we need to test the patch. Then, we'll go from there.

Andrew

Options: ReplyQuote
Re: Bug 113007 Patch
Posted by: ZeroMC
Date: July 05, 2002 02:18PM

sure... i know you never stopped development...
But my english is very bad and i didn't know how to express what i meant ;)
Sorry...

ZeroMC

Options: ReplyQuote
Re: Bug 113007 Patch
Posted by: Andrew
Date: July 05, 2002 03:30PM

Zero,

No Problem. I understand. By the way, that patch was checked in by Mark who works on K-Meleon. It's already been checked into our code.

Andrew

Options: ReplyQuote
Re: Bug 113007 Patch
Posted by: ZeroMC
Date: July 05, 2002 03:32PM

Great! smiling smiley
I hope it will work.

Options: ReplyQuote
Re: Bug 113007 Patch
Posted by: Andrew
Date: July 06, 2002 02:50AM

Zero,

I all of our testing so far, it has worked great.

Andrew

Options: ReplyQuote
Re: Bug 113007 Patch
Posted by: Marvin
Date: July 07, 2002 08:37PM


Will this be included in a new Release (0.7) soon? Or will it be available only in developers version.

Excuse my english 'cause I am german. ;-)

Marvin

Options: ReplyQuote
Re: Bug 113007 Patch
Posted by: Al.
Date: July 08, 2002 06:58AM

Well both really. The code has been put into the latest beta, which means it will also be in the final release of 0.7, as it fixes one of the problems that K-Meleon has been experiencing.

Options: ReplyQuote
Re: Bug 113007 Patch
Posted by: ZeroMC
Date: July 08, 2002 03:18PM

Well... the new beta is... GREAT smiling smiley
I love it! Maybe I can help with a german translation? :-)

Options: ReplyQuote


K-Meleon forum is powered by Phorum.