General :  K-Meleon Forum
General discussion about K-Meleon. 
K-Meleon 74 - a small history adjustment
Posted by: JamesD
Date: June 26, 2014 04:17AM

I have found this adjustment to history to be useful. It works on code from Dorian. It may not work on other versions. It adds some options to the history menus and buttons.

Changes for History - KM 74 Beta 4

[1] Main.kmm

Line 128+- Delete $kHistory line

Line 205+- Overwrite code section 'View Menu' with these lines

# view menu
setmenu("Tool&bars",macro,$__o,"kmPrefs(toolbars)");
$kPrivacy?$__i=2:$__i=1;
setmenu("Histor&y",macro,$__o,"kmPrefs(history)",$__i);
$kTabs?setmenu("T&abs",macro,$__o,"kmPrefs(tabs)",0):0;
$kTabs?setmenu("T&abs",separator,1):0;

Line 796+- Insert this code after '$OnInit=$OnInit."_Open_BuildMenu;";'
but prior to '# ----- Special Macro Execution (based on OpenURL and pref)'.

# PLACES (history)

Places_History{
macroinfo=_("Open the history");
$OpenURL="chrome://history/content/history.xul"; &OpenURL_InNewWindow;
}

[2] Menus.cfg [ root\browser\defaults\settings\menus.cfg ]

Line 60+- Replace the history section with this code

# ----- History

%ifplugin macros
Histor&y{
View &History=macros(Places_History)
%ifplugin privacy
&Clear History=privacy(ClearHistory)
%endif
@SHistory
}
%endif

[3] Delete the file places.kmm from root\macros.

[4] Use the infomation at the bottom of this to change (if needed) the toolbars.cfg file of the skin(s)
which you use.

[5] To verify your changes are correct, start KM and go to several webpages in the current window.
Then click on View - History. You should have View History, Clear History, Options..., and a list of
the sites you have visited in the current window. You should also have a similar display if you
right click the history button. The accel keyset CTRL + H is already in place in line 114 of accel.cfg.


For the file named 'toolbars.cfg' in each skin, verify that the
history section is as shown below.


Klassic

%ifplugin macros
History{
history(Places_History)|Histor&y
View History. Right-click for more options.
toolhot.bmp[12]
toolcold.bmp[12]
tooldead.bmp[12]
}
%endif


AuraAlpha

%ifplugin macros
History{
macros(Places_History)|Histor&y
View History. Right-click for more options.
mainbarhot.bmp[7]
mainbarcold.bmp[7]
mainbarcold.bmp[7]
}
%endif


AuraAlpha(Compact)

%ifplugin macros
History{
macros(Places_History)|Histor&y
View History. Right-click for more options.
mainbarhot.bmp[6]
mainbarcold.bmp[6]
mainbarcold.bmp[6]
}
%endif


AuraAlpha(Large)

%ifplugin macros
History{
macros(Places_History)|Histor&y
View History. Right-click for more options.
mainbarhot.bmp[6]
mainbarcold.bmp[6]
mainbarcold.bmp[6]
}
%endif

Minimal no history defined

Options: ReplyQuote
Re: K-Meleon 74 - a small history adjustment
Posted by: rodocop
Date: June 26, 2014 07:33AM

Yes, it works!

Thank you, James!


Try K-Meleon-1.6db+NS by dugbug // KM-16-S2014 by Fred // 1.6beta2.6 by JamesD

K-Meleon Twin+ Download for modern browsers =//= Download for old ones =//= Discuss it!!!

New KM74.0 for test and feedback! Get it there!


Options: ReplyQuote
Re: K-Meleon 74 - a small history adjustment
Posted by: guenter
Date: June 27, 2014 12:25AM

Did You already send Your alteration to Dorian?

Also:

Quote
JamesD
macros(Places_History)|Histor&y
View History. Right-click for more options.

Any skin.

Has IMHO to be Your version no matter whether the other changes are accepted.

Reason: "View History. Right-click for more options." is in the kmeleon.kml.
It only autotranslates into the other languages if exactly this phrase is used.

Else the new string's "View History." translation has to be added to the kml and 150 odd old skins need to be updated to this extra change. sad smiley


p.s. The same for the browser configuration button.

Browser Con&figuration{
Compact Menu New
&Tools

The red phrase is already defined in the current kmeleon.kml.


        Browser Con&figuration{
	Compact Menu New
	Tools


The currently used blue phrase is not defined and thus does not translate.



Edited 1 time(s). Last edit at 06/27/2014 12:43AM by guenter.

Options: ReplyQuote
Re: K-Meleon 74 - a small history adjustment
Posted by: JamesD
Date: June 27, 2014 04:02AM

No, I have not yet sent this to Dorian.

I thought the string existed. What was there before change was only 'View History.'.

View History. Right-click for more options.=Voir l'historique. Clic-Droit pour plus d'options.

View History. Right-click for more options.=Verlauf anzeigen. Für mehr Optionen rechts-klicken.

I don't think that I used the word 'tools' in any form for history. Am I missing some point? I can change things if required.

If Dorian decides to use this, I am sure he will see to correct matches in kml file.

Options: ReplyQuote
Re: K-Meleon 74 - a small history adjustment
Posted by: guenter
Date: June 27, 2014 03:00PM

Quote
JamesD
No, I have not yet sent this to Dorian.

I thought the string existed. What was there before change was only 'View History.'.

View History. Right-click for more options.=Voir l'historique. Clic-Droit pour plus d'options.

View History. Right-click for more options.=Verlauf anzeigen. Für mehr Optionen rechts-klicken.

I don't think that I used the word 'tools' in any form for history. Am I missing some point? I can change things if required.

If Dorian decides to use this, I am sure he will see to correct matches in kml file.

No, You did it perfectly when You checked whether Your change existed in the kml. Plus it was there and for the history item. I did it the same way as You, when I unified and updated some old skins in 2007. Take existing strings from the main kml (if that has the texts You need) that way You need not extra kml.grinning smiley

Dorian did not check whether the strings are in the kml. Neither did he add them before we translated. Remember when he started 74, he did not know who was still here. disrupted and I created the last skins on the basis of kko's skins and even older sources. Dorian could not know all the small print. And now when some are still here he doesn't have too anymore. smiling smiley

I already contemplated to report both as minor bugs. With the fix You chose and suggesting to re-use &Tools. That is a string from a normal menue item, but it can be re-used to make the changed text in the skins autostranslate. But I forgot before I got around to it. Senior momemnts. grinning smiley

The button is near the end of toolbars.cfg. In Dorian's new compact skin, it is line 457 ff.

Browser Con&figuration{
Compact Menu New
&Tools



Edited 1 time(s). Last edit at 06/28/2014 01:29AM by guenter.

Options: ReplyQuote
Re: K-Meleon 74 - a small history adjustment
Posted by: Dorian
Date: July 10, 2014 12:35AM

Quote
JamesD
I have found this adjustment to history to be useful. It works on code from Dorian. It may not work on other versions. It adds some options to the history menus and buttons.

The missing "options" was obviously a bug. Not sure why you removed the kmm though.

Options: ReplyQuote
Re: K-Meleon 74 - a small history adjustment
Posted by: JamesD
Date: July 10, 2014 03:54AM

There were four items in the kmm file. Of the two macros, a setaccel statement, and a menu item only one macro was used, the setaccel was a duplicate, and the history item from the setmenu into TOOLS did not seem to be a correct location. It may be just because I use the menus and buttons, rather than skin without.

I thought moving the remaining macro to main.kmm would mean fewer things to keep maintained.

I would not suggest this as meeting everyone's requirements. I was just sharing my personal choice.

Options: ReplyQuote


K-Meleon forum is powered by Phorum.