Re: KM 1.6 and AdBlock
Posted by: jk--
Date: January 17, 2011 05:17AM

I've currently got adblockplus 1.2.2 working with k-meleon 1.6beta2!

More info to come...

Re: KM 1.6 and AdBlock
Posted by: jk--
Date: January 17, 2011 11:41AM

OK if anyone else wants to test it, here it is. It's obviously a work in progress.
http://www.digivill.net/~joykillr/kmeleon/adblockplus-kmeleon-1.2.2-en-US-unofficial-0.5.zip

Firstly, the official adblock kplugin dll doesn't apparently doesn't work in 1.6 so the adblock toolbutton isn't showing up.

The Configuration can be accessed through Tools -> AdBlockPlus. This is the main preference window.

The biggest problem right now is the Blockable Elements window isn't working correctly... it can't get the element list for the current page. This may be because without the DLL, opening the chrome page with "opennew" results in a new parent window.


What DOES work:
1. Adblocking off existing pattern lists.
2. Adding new filters in the configuration
3. Importing of pattern lists
4. Subscriptions

What DOESN'T work:
1. Blockable Elements Window
2. Toolbar/Statusbar Icon

edit: updated link, the previous version had an oversight.



Edited 1 time(s). Last edit at 01/17/2011 12:49PM by jk--.

Re: KM 1.6 and AdBlock
Posted by: Alex.Tarantul
Date: January 17, 2011 10:12PM

Great news!
Now I'm ready to test that stuff smiling smiley
I quickly get back to Wladimir Palant and ask to help us!

My blog about K-Meleon
http://kmeleon-ru.blogspot.com/

Re: KM 1.6 and AdBlock
Posted by: Alex.Tarantul
Date: January 18, 2011 01:03AM

@all
Give me two or three days - I will examine the source code. I think I can fix the code slightly so that all elements have been working...
In addition, I am waiting a reply from Wladimir Palant smiling smiley

My blog about K-Meleon
http://kmeleon-ru.blogspot.com/

Re: KM 1.6 and AdBlock
Posted by: Matt
Date: January 18, 2011 01:10AM

That's great, Alex! Thanks in advance and thanks goes to jk-- as well. I'm gonna wait patiently smiling smiley

Re: KM 1.6 and AdBlock
Posted by: 4td8s
Date: January 18, 2011 02:14AM

wonderful! smiling smiley

once the new ABP code is released, I will test it in both K-meleon 1.6 beta 2 AND K-meleon 1.7 alpha 2 (yes, folks there is a KM 1.7 out there)

Re: KM 1.6 and AdBlock
Posted by: chinarobin
Date: January 18, 2011 07:16PM

yes,i confirm that list can be used,and works well, but cannot use right-click to block the image that you dont want to show.drool smiley

thank you all!



Edited 1 time(s). Last edit at 01/18/2011 07:28PM by chinarobin.

Re: KM 1.6 and AdBlock
Posted by: Alex.Tarantul
Date: January 18, 2011 08:05PM

Colleagues, I received a reply from Vladimir. Here is the text:
==========================================================
I know that Adblock Plus works in K-Meleon with no problems, if you do not need a user interface. The problem is just to make the UI functional. Macros will not succeed.
Source code for Adblock Plus for K-Meleon moved to https://hg.adblockplus.org/adblockpluskmeleon/
Try to run the nightly builds, they are clearly more efficient.
Here: https://adblockplus.org/devbuilds/adblockpluskmeleon/
Automatic creation of builds does not work (the server is Linux), but at least it will automatically create a list. Must also update manually, of course.
==========================================================

Incidentally, I'm (Alex) now looked superficially the structure of files and folders of AdBlock Plus, and found that there were some misunderstandings ...
For example, in adblockplus.manifest specified skin "classic", but "new" version of AdBlock Plus structure of folders and files has changed, and there is NO skin classic...So must be carefully checked. Who can help with this?

My blog about K-Meleon
http://kmeleon-ru.blogspot.com/

Re: KM 1.6 and AdBlock
Date: January 19, 2011 01:47PM

Alex, there doesn't need to be a folder named "classic" for the skin - it was only there for compatibility with SeaMonkey 1.x. Now that everybody moved on (even K-Meleon) it is unnecessary.

Please see the announcement here, it lists in particular the known issues with the current development builds: https://adblockplus.org/development-builds/adblock-plus-for-k-meleon-development-builds-are-available-again.

Re: KM 1.6 and AdBlock
Posted by: Alex.Tarantul
Date: January 19, 2011 02:50PM

Thanks, Wladimir!
Now we will try to do something... smiling smiley

My blog about K-Meleon
http://kmeleon-ru.blogspot.com/

Re: KM 1.6 and AdBlock
Posted by: jk--
Date: January 19, 2011 05:10PM

Quote
Alex.Tarantul
==========================================================
I know that Adblock Plus works in K-Meleon with no problems, if you do not need a user interface. The problem is just to make the UI functional. Macros will not succeed.
==========================================================

The only js code that seemed to be conflicting in 1.2.2 was the fennec compatibility code.

And some code that queried the firefox extension manager.

Quote
Wladimir Palant
Please see the announcement here, it lists in particular the known issues with the current development builds: https://adblockplus.org/development-builds/adblock-plus-for-k-meleon-development-builds-are-available-again.

This is good news!
https://adblockplus.org/devbuilds/adblockpluskmeleon/



Edited 3 time(s). Last edit at 01/19/2011 05:37PM by jk--.

Re: KM 1.6 and AdBlock
Posted by: 4td8s
Date: January 20, 2011 12:21AM

Quote
jk--

What DOESN'T work:
1. Blockable Elements Window
2. Toolbar/Statusbar Icon

well jk, if you download the latest ABP for K-meleon dev build here:
https://adblockplus.org/devbuilds/adblockpluskmeleon/

the toolbar & status bar icons of ABP seem to work; just right-click on the ABP icon in KM and a context menu appears. I'm using the latest dev build of ABP under K-meleon 1.6b2.

Blockable Elements UI still needs some improvement. Also selecting About Adblock Plus from the ABP Help menu in the Preferences dialog box shows an empty window instead of displaying the ABP version number and credits.



Edited 2 time(s). Last edit at 01/21/2011 12:13AM by 4td8s.

Re: KM 1.6 and Adblock Plus
Posted by: surfer
Date: January 20, 2011 12:42AM

Quote
4td8s
I'm using the latest dev build of ABP under K-meleon 1.6b2. I have yet to test this with K-meleon 1.7a2.

Quote
Wladimir Palant
The files in this directory are work in progress towards creating an Adblock Plus version that would be compatible with K-Meleon 1.6. These builds will work only with K-Meleon 1.6 and they are not completely functional yet.
https://adblockplus.org/devbuilds/adblockpluskmeleon/

Re: KM 1.6 and Adblock Plus
Posted by: 4td8s
Date: January 21, 2011 12:16AM

Quote
surfer

Quote
Wladimir Palant
The files in this directory are work in progress towards creating an Adblock Plus version that would be compatible with K-Meleon 1.6. These builds will work only with K-Meleon 1.6 and they are not completely functional yet.
https://adblockplus.org/devbuilds/adblockpluskmeleon/

indeed. latest ABP dev build for KM is only for KM 1.6 and not for any other version, not even for KM 1.7 (sorry, didn't pay close enough attention). found out the unpleasant way that the ABP dev builds for KM there crashes KM 1.7.

oh well, I'll wait for newer KM 1.7 alphas/betas and newer ABP dev builds for KM to be released.



Edited 1 time(s). Last edit at 01/21/2011 12:16AM by 4td8s.

Re: KM 1.6 and Adblock Plus
Posted by: sickley
Date: January 25, 2011 01:44AM

this is fantastic news! thanks for everyone's hard work! grinning smiley

Re: KM 1.6 and Adblock Plus
Posted by: Matt
Date: January 25, 2011 02:42AM

New ABP build fixes some issues.

Quote
Wladimir Palant
The current development build (Adblock Plus for K-Meleon 1.3.5a2.145) fixes some issues:

* ABP icon state now works correctly with multiple windows
* Issue reporter succeeds sending a report
* About dialog is available now
* Links will open correctly in a K-Meleon tab now

Remaining known issues:

* List of blockable items doesn’t show anything
* K-Meleon crashes if the report link is clicked after submitting the report
* ABP icon state doesn’t update correctly when switching from/to a blank tab
* Window sizes aren’t persisted properly
* “Tabs on Flash and Java” feature doesn’t work
* Left-click and middle-click on the icons won’t work
* Search in Preferences window is only partially working (this is K-Meleon bug 1237)
https://adblockplus.org/development-builds/some-k-meleon-issues-fixed

Re: KM 1.6 and Adblock Plus
Posted by: 4td8s
Date: January 26, 2011 03:26PM

Quote
Matt
New ABP build fixes some issues.

Quote
Wladimir Palant
The current development build (Adblock Plus for K-Meleon 1.3.5a2.145) fixes some issues:

* ABP icon state now works correctly with multiple windows
* Issue reporter succeeds sending a report
* About dialog is available now
* Links will open correctly in a K-Meleon tab now

Remaining known issues:

* List of blockable items doesn’t show anything
* K-Meleon crashes if the report link is clicked after submitting the report
* ABP icon state doesn’t update correctly when switching from/to a blank tab
* Window sizes aren’t persisted properly
* “Tabs on Flash and Java” feature doesn’t work
* Left-click and middle-click on the icons won’t work
* Search in Preferences window is only partially working (this is K-Meleon bug 1237)
https://adblockplus.org/development-builds/some-k-meleon-issues-fixed

EXCELLENT! grinning smiley
just installed the newest dev build (145) of ABP under KM 1.6b2.

Re: KM 1.6 and Adblock Plus
Posted by: Matt
Date: January 28, 2011 03:53PM

Wladimir made a new dev build (1.3.5a2 149) smiling smiley

changes:

Restored status bar icon's left-click functionality
Fixed: "Open menu" as left-click action on toolbar icon doesn't work
Fixed middle-click processing on toolbar and status bar icons
Fixed: abp: links do not work


UPDATE: dev build 1.3.5a2.151 available

changes:

Add missing findbar preference and interface ourselves to work around K-Meleon bug 1237
Fix window.openDialog() emulation, simulate window.opener on dialogs opened (required for list of blockable items)

Download: https://adblockplus.org/devbuilds/adblockpluskmeleon/



Edited 1 time(s). Last edit at 01/28/2011 07:49PM by Matt.

Re: KM 1.6 and Adblock Plus
Posted by: Matt
Date: January 28, 2011 10:17PM
Re: KM 1.6 and Adblock Plus
Posted by: ndebord
Date: January 30, 2011 12:19AM

Matt,

One bug.. Using Klassic theme, when you click on Options and tick off Status Bar and remove tick from Toolbar, the little red icon continues to show up in both places.

N

Re: KM 1.6 and Adblock Plus
Posted by: Matt
Date: January 30, 2011 12:43AM

Can't reproduce it with AuraAlpha nor Klassic, which looks awful but it's just my opinion.

ABP 1.3.5a2.155, K-M Beta2, Win7

Re: KM 1.6 and Adblock Plus
Posted by: ndebord
Date: January 30, 2011 01:02AM

Quote
Matt
Can't reproduce it with AuraAlpha nor Klassic, which looks awful but it's just my opinion.

ABP 1.3.5a2.155, K-M Beta2, Win7

Matt,

I'll try a fresh install and make adblock the first extension and get back to you.

P.S. OK, fresh install and it doesn't matter what I tell it to do in Options. I get the little AdBlock icon in both toolbar and status.

adblockpluskmeleon-1.3.5a2.155

N



Edited 2 time(s). Last edit at 01/30/2011 07:40AM by ndebord.

Re: KM 1.6 and Adblock Plus
Posted by: 4td8s
Date: February 04, 2011 07:14AM

Quote
ndebord
Quote
Matt
Can't reproduce it with AuraAlpha nor Klassic, which looks awful but it's just my opinion.

ABP 1.3.5a2.155, K-M Beta2, Win7

Matt,

I'll try a fresh install and make adblock the first extension and get back to you.

P.S. OK, fresh install and it doesn't matter what I tell it to do in Options. I get the little AdBlock icon in both toolbar and status.

adblockpluskmeleon-1.3.5a2.155

--EDITED--

UPDATE: the new Adblock Plus toolbar icon still stays there, even when I uncheck the ABP toolbar option from its Options/Preferences menu. but the ABP status bar icon option turns on and off correctly on Win2000, XP, Vista and Seven.



Edited 2 time(s). Last edit at 02/04/2011 07:41AM by 4td8s.

Re: KM 1.6 and Adblock Plus
Posted by: ndebord
Date: February 04, 2011 07:32AM

Quote
4td8s

the bug can't be re-produced in either Vista or Win7, ndebord. new Adblock Plus toolbar and status bar icon options work correctly in Vista/Win7.

on other versions of Windows (like Win2k or WinXP), the new Adblock Plus toolbar icon still stays there, even when I uncheck the ABP toolbar option from its Options/Preferences menu. but the ABP status bar icon option turns on and off correctly on Win2000/XP.

45d8s,

OK then, as I run XP PRO SP3, I guess I can live with 2 adblock plus toolbar icons for now.

N

Re: KM 1.6 and Adblock Plus
Posted by: 4td8s
Date: February 04, 2011 07:46AM

Quote
ndebord

45d8s,

OK then, as I run XP PRO SP3, I guess I can live with 2 adblock plus toolbar icons for now.

ndebord, I've just edited my previous post. ABP toolbar icon option in any version of Windows does not work properly. ABP status bar icon, though, works as expected.

Re: KM 1.6 and Adblock Plus
Posted by: ndebord
Date: February 04, 2011 12:21PM

Quote
4td8s
Quote
ndebord

45d8s,

OK then, as I run XP PRO SP3, I guess I can live with 2 adblock plus toolbar icons for now.

ndebord, I've just edited my previous post. ABP toolbar icon option in any version of Windows does not work properly. ABP status bar icon, though, works as expected.

45d8s,

Thanks... this is how KM 1.6.0b2 adblock looks on my XP PRO SP3 laptop with Toolbar turned off and status bar turned on.






N

Re: KM 1.6 and Adblock Plus
Posted by: luk3Z
Date: February 05, 2011 04:23AM

Quote
ndebord
Quote
4td8s
Quote
ndebord

45d8s,

OK then, as I run XP PRO SP3, I guess I can live with 2 adblock plus toolbar icons for now.

ndebord, I've just edited my previous post. ABP toolbar icon option in any version of Windows does not work properly. ABP status bar icon, though, works as expected.

45d8s,

Thanks... this is how KM 1.6.0b2 adblock looks on my XP PRO SP3 laptop with Toolbar turned off and status bar turned on.


(...)

This is why I still using KM 1.5.4 tongue sticking out smiley

Re: KM 1.6 and Adblock Plus
Posted by: jsnj
Date: February 05, 2011 05:29AM

Quote
4td8s
...I've just edited my previous post. ABP toolbar icon option in any version of Windows does not work properly. ABP status bar icon, though, works as expected.

Hmm...did you do anything different on your KM on Win7 that might have caused the change? I ask because on my Win7 64b laptop there's no immovable abp toolbar problem, but on my WinXP SP3 desktop, there is.

Re: KM 1.6 and Adblock Plus
Posted by: sliderule
Date: February 05, 2011 05:45AM

I am using K-Meleon 1.6.2Beta with Windows XP SP3 and AdBlock.

I too have the AdBlock LINE, but, it is NOT a TOOLBAR. Let me explain.

If I go to Full Screen ( F11 ) . . . it still shows. Second, I changed the BACKGROUND colour of my toolbars . . . and . . . the AdBlock area is a DIFFERENT colour.

I suspect, but, cannot say for certain . . . it is part of MANIFEST ? ? ?

Just a thought.

Sliderule

Re: KM 1.6 and Adblock Plus
Posted by: jsnj
Date: February 05, 2011 06:08AM

Quote
sliderule
I am using K-Meleon 1.6.2Beta with Windows XP SP3 and AdBlock.

I too have the AdBlock LINE, but, it is NOT a TOOLBAR. Let me explain.

If I go to Full Screen ( F11 ) . . . it still shows. Second, I changed the BACKGROUND colour of my toolbars . . . and . . . the AdBlock area is a DIFFERENT colour.

I suspect, but, cannot say for certain . . . it is part of MANIFEST ? ? ?

Just a thought.

Sliderule

My XP machine is not working at the moment but if it's a manifest problem, try removing lines not applicable to KM. 30-35, then 1-8.

K-Meleon forum is powered by Phorum.