K-Meleon :: Improvement requests

Improvement requests : K-Meleon Forum

Use this forum to talk about a feature you're missing. Use the bug tracker to report it if necessary.

Goto: Forum List•Message List•Search•Log In

Your Name:
Subject:

Help information

[quote=JamesD]
@ siria

I agree that FavRenAdd should be in the KM Extentions.  The thing is that I have never done an extension.  I am used to the "MacroLibrary" http://kmeleon.sourceforge.net/wiki/KmmFavRenAdd being the share point for these types of things.

A bit of history will perhaps help here.  FavRenAdd (ASCII) was my first big macro.  It is old.  I had to ask for and was given quite a bit of help during its creation. The first version went into the MacroLibrary in August of 2007.  Right away there were user problems because of limit on the length of the string passed in the "exec" statement.  I updated to the method currently in use for the ASCII version.  Not having any language skills except English, I did not know that method would not work for users requiring UTF-8.  Later I created the international version which passes the strings in a different method.  There has been no updates on the code until the change you found to make alternate locations work.

If we are to create an extension for FavRenAdd then I think it should also include FavAltDir.kmm for alternate locations, and Reload_IE_Fav.kmm for reloading the favorites view.

I have, as you suggested, added "[Share favorites with I.E.]" in the two places where only "Default" was used before.  Very good suggestion, thank you.

I think you might have the more complete code for Reload_IE_Fav.kmm.  Did I not see some code in your post that automatically selects between cmd.exe and command.com?  Do we need desga2 to sign off on using Reload_IE_Fav in the extension?  I am sure he would not mind, but I would like to ask anyway.

I have looked for some solution to the flashing of the cmd/command window, but I have not found a way to run it completely in the background.  In cmd, one can right click on the bar at the top of window and get to the properties where the color and position can be changed.  I do not know if that is available in command.  Perhaps you could check.  This not something a program could do.

Another thing is our target audience.  If we limit ourselves to users of KM 1.5.x then no change is necessary.  However if we wish to allow users of older versions, then I would have to change the "if" statements in FavAltDir.kmm and use instead the old conditional statement.  Also the "macroinfo" statements in FavAltDir.kmm and Reload_IE_Fav.kmm would have to be removed.

Updated macro
[b]FavAltDir.kmm[/b]

[code]
#  K-Meleon Macros (http://kmeleon.sourceforge.net/wiki/index.php?id=MacroLanguage)
#
# ---------- FavAltDir.kmm
# ---------- For changing the pref which holds the location of "Favorites".
#----------- Note the "windows standard" location does not use the pref. 
#
# Dependencies        : KM 1.5.x or later, main.kmm
# Resources           : ie favorites plugin  
# Preferences         : "kmeleon.plugins.favorites.directory"
# Version             : 1.1   2010-01-02
# Author			  : JamesD  
# --------------------------------------------------------------------------------

_FavAltDir_Action {
macroinfo="Change location of Favorites folder";
$_FavAltDir_AltDir =  getpref(STRING, "kmeleon.plugins.favorites.directory");
if ( length($_FavAltDir_AltDir) == 0) { $_FavAltDir_AltDir = "DEFAULT [Share favorites with I.E.]"; }
$_FavAltDir_Change = confirm( $_FavAltDir_AltDir, "Change from location shown?  Cancel resets default", YESNOCANCEL, QUESTION );
if ($_FavAltDir_Change == "YES") { 
	$_FavAltDir_AltDir = promptforfolder(_("Select an alternate Favorites folder"), getfolder(ProfileFolder));
	$_FavAltDir_AltDir =  $_FavAltDir_AltDir."\\" ;
	setpref(STRING, "kmeleon.plugins.favorites.directory", $_FavAltDir_AltDir);
	alert("K-Meleon must be restarted\n\nfor the change to\n\n".$_FavAltDir_AltDir."\n\n to take effect.", "RESTART REQUIRED", EXCLAIM) ;
	}
if ($_FavAltDir_Change == 0) {
	delpref("kmeleon.plugins.favorites.directory");
	alert("K-Meleon must be restarted\n\nfor the change to\n\nDEFAULT [Share favorites with I.E.]\n\n to take effect.", "RESTART REQUIRED", EXCLAIM) ;
	}
}

_FavAltDir_BuildMenu {
	# add another option to Favorites menu
	setmenu("F&avorites",macro,"Alternate Directory",_FavAltDir_Action,3);
}

## - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
$OnInit=$OnInit."_FavAltDir_BuildMenu;";
$macroModules=$macroModules."FavAltDir;";
[/code][/quote]

K-Meleon forum is powered by Phorum.