K-Meleon :: General

General : K-Meleon Forum

General discussion about K-Meleon.

Goto: Forum List•Message List•Search•Log In

Your Name:
Subject:

Help information

[quote=deadlock]
@disrupted
Sorry for posting before thinking.
I'll edit this post, while work is in progress.

--
[b]Update1:[/b]
1) K-Meleon opens url successful (Title is 'Page Load Error').
2) K-Meleon doesn't ask XUL for cert-errors!
3) K-Meleon looks for
[i]https://www.mrtech.com/favicon.ico[/i]
although a cert error occurred.
4) XUL opens chrome-window with 2'nd title 'Page Load Error'

This is a test fix, where step 3 and 4 are skipped.
All other pages can load their site-icons.
(Filename is BrowserImpl.cpp, my changes are red.)

if (type.Equals(NS_LITERAL_STRING('DOMContentLoaded')))
{ 
// DOMContentLoaded is not send if the page is reloaded from cache 
// Nevertheless I'm using it to get the IE favicon without waiting 
// for all images of the page to be loaded

[color=#FF0033]NS_ENSURE_TRUE(m_pBrowserFrameGlue, NS_ERROR_FAILURE);
CString title;
m_pBrowserFrameGlue->GetBrowserTitle(title);
if(_tcsncmp(_T('Page Load Error'),title,15)==0)
{
return NS_ERROR_FILE_ACCESS_DENIED;
}[/color]

m_pBrowserFrameGlue->SetFavIcon(nsnull);
return NS_OK;
}

[b]Update2:[/b]
Found out what filters warning icon:
'chrome://global/skin/icons/warning-16.png'

CBrowoserImpl.cpp -> HandleEvent 'DOMLinkAdded'

rv = secMan->CheckLoadURI(docUri, favUri,
nsIScriptSecurityManager::STANDARD);
/* failure means it didn't pass the security check */
if (NS_FAILED (rv)) return NS_OK;

No Chrome icons pass the lines above.
GRE 1.9.1 nsIScriptSecurityManager killed Console2 too.

[b]Update3:[/b]
rv = secMan->CheckLoadURI(docUri, favUri,
nsIScriptSecurityManager::STANDARD
[color=#0033FF]| nsIScriptSecurityManager::ALLOW_CHROME);[/color]
/* failure means it didn't pass the security check */
if (NS_FAILED (rv)) return NS_OK;

This change allows loading chrome icons.
The yellow warning is in Caption and URLBar again.

[b]Update4:[/b]
[i]Tried to list all involved preferences:[/i]

(For title, urlbar, tabs and plugins.)
[color=#003388]kmeleon.favicons.show[/color]

(To disable titleBar icons if show enabled.)
[color=#003388]kmeleon.favicons.titleBar[/color]

(To disable bookmarks icons if show enabled.)
kmeleon.plugins.bookmarks.displaySiteicon

(Does it cache chrome, and what happens if not?)
[color=#003388]kmeleon.favicons.cached[/color]

[i]Chrome usage:[/i]
(for title, urlbar, tabs and plugins)
[color=#003388] browser.chrome.favicons[/color]

[color=#008800]if (!theApp.preferences.GetBool('browser.chrome.favicons', TRUE))
{[/color]
rv = secMan->CheckLoadURI(docUri, favUri,
nsIScriptSecurityManager::STANDARD);
[color=#006600]}
else
{
rv = secMan->CheckLoadURI(docUri, favUri,
nsIScriptSecurityManager::STANDARD
| nsIScriptSecurityManager::ALLOW_CHROME);
}[/color]

[b]Update5:[/b]
Problem solved: (no 2'nd popup and working favicon refresh)
1) Allow load of chrome images on netError.
2) Block favicon if invalid cert for URI. (warning-16.png is not blocked, it uses siteicon code.)
3) Enable show favicon if matching overwrite cert rule exists.
4) Force refresh favicon at end of overwrite button code.

todo: Test HTTPS site with siteicon and without favicon.

Found several http sites with siteicons and favicons.
Last loaded icon is displayed. Any ideas?

Micro$oft favicons are:
[color=#CC0066]<server>/favicon.ico[/color]

Siteicons are:
[color=#CC0099]rel='icon' or rel='shortcut icon' src='picture'[/color]

--
Next I would try to fix this (or later):
- chrome-windows with parameters
[s]- remove all size to content changes that where added[/s]
- remove display problems if 'size to content' is used.
[color=#CC00CC](update: fixed by minimize + moving up 2000 pixels on create and moving back on resize.)[/color][/quote]

K-Meleon forum is powered by Phorum.