K-Meleon Bugs - Bug 1237 - Undefined entity error in findbar.xml

Summary:	Undefined entity error in findbar.xml
Creator:	Wladimir Palant	Date:	2010-06-28 15:25:37
Project:	K-Meleon	Owner:	desga2
Status:	Open	Severity:	Normal
Version:	1.6a4	Target Version:	Unknow

User-agent: Firefox/3.6.6

Adblock Plus uses Gecko's <findbar> widget. However, in K-Meleon 1.6a4 it doesn't work, following error message:

Error: undefined entity
Source file: jar:file:///C:/.../chrome/embed.jar!/content/global/bindings/findbar.xml
Line: 218, Column: 7
Source code:
<xul:toolbarbutton anonid="find-closebutton"

From what it looks like, findbar.dtd is missing from the embed.jar locale altogether.

Comments

dorian 2010-07-03 07:23:07

[Changed Status from "Unconfirmed" to "Open"]

guenter 2010-11-18 21:28:25

K-Meleon does not have findbar.xml xml in his chrome. It is a XUL item unique to XUL based browsers.

guenter 2010-11-18 22:27:54

Correction. ...not have a working findbar.xml in his chrome. ...

desga2 2010-11-19 20:57:25

Both files (/chrome/embed.jar!/content/global/bindings/findbar.xml and findbar.dtd and findbar.properties in locale) included in 1.6 Beta chrome.
But K-Meleon don't use the xul findbar, I don't know if findbar xul code work in K-Meleon.

guenter 2010-11-20 14:52:22

Yes it has the file, but never had it working. Even before You did work on chrome. :(

Adding missing findbar.dtd that W. Palant mentioned has not improved much.

Find.xpt might also be needed. I tried with find.xpt because there is a group of errors that stops line finding service of viewsource. I do not know whether this has the same reason? But even with find.xpt I have not had better results for viewsource.

Wladimir Palant 2011-01-19 08:07:11

The findbar is a default XUL widget nevertheless and might be used by extensions - https://developer.mozilla.org/en/XUL/findbar

Things are somewhat better now, the findbar is partially working. What is missing now are preferences, Firefox 3.5 has:

pref("accessibility.typeaheadfind", false);
pref("accessibility.typeaheadfind.timeout", 5000);
pref("accessibility.typeaheadfind.linksonly", false);
pref("accessibility.typeaheadfind.flashBar", 1);

And nsITypeAheadFind interface is missing as well. K-Meleon only has suitetypeaheadfind.xpt containing nsISuiteTypeAheadFind - I don't know what it is but SeaMonkey 2 has the usual nsITypeAheadFind interface.

Wladimir Palant 2011-01-21 11:34:30

My comment above was partly wrong, turns out that K-Meleon already has typeaheadfind preferences - under greprefs. The flashBar preference is missing however. I verified that adding components/typeaheadfind.xpt and this pref:

pref("accessibility.typeaheadfind.flashBar", 1);

makes the findbar work without any issues.

Wladimir Palant 2011-01-28 11:46:31

New Adblock Plus packages now contain this file as well as the additional preference. However, I'm do not like messing with Gecko from an extension, I hope that this issue will still be fixed before K-Meleon 1.6 is released.

desga2 2011-01-30 20:52:54

OK Wladimir, I'll added all your requeriments in next 1.6 release.
Thanks you for your help and work for Adblock Plus K-Meleon support.
[Changed Owner from ".Nobody" to "desga2"]